Bug 98752

Summary: [CSS Regions] Create a separate list for the invalid regions
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: WebCore Misc.Assignee: Andrei Bucur <abucur>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, donggwan.kim, eric, gyuyoung.kim, mihnea, rakuco, webkit.review.bot
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andrei Bucur
Reported 2012-10-09 04:46:54 PDT
The regions that create dependency cycles between flows (invalid regions) and valid regions reside in the same list. This adds complexity to the code because iterations through the region list need to check the validity of the items. Getting the first/last valid region is also overly-complicated (the first/last invalid regions need to be skipped). There should be a separate low traffic list for the invalid regions that's used when dependencies between flow threads change.
Attachments
Patch (35.81 KB, patch)
2012-10-09 08:53 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch (33.41 KB, patch)
2012-10-10 01:36 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch (36.61 KB, patch)
2012-10-10 05:18 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrei Bucur
Comment 1 2012-10-09 08:53:22 PDT
Created attachment 167765 [details] Patch
WebKit Review Bot
Comment 2 2012-10-09 09:45:41 PDT
Comment on attachment 167765 [details] Patch Attachment 167765 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14248101 New failing tests: fast/regions/flows-dependency-same-flow.html fast/frames/frame-limit.html
Andrei Bucur
Comment 3 2012-10-10 01:36:49 PDT
Created attachment 167958 [details] Patch
WebKit Review Bot
Comment 4 2012-10-10 03:41:11 PDT
Comment on attachment 167958 [details] Patch Attachment 167958 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14229968 New failing tests: fast/regions/flows-dependency-same-flow.html
Andrei Bucur
Comment 5 2012-10-10 05:18:07 PDT
Created attachment 167983 [details] Patch
Andreas Kling
Comment 6 2012-10-10 09:41:29 PDT
Comment on attachment 167983 [details] Patch Love it! r=me
WebKit Review Bot
Comment 7 2012-10-10 10:11:10 PDT
Comment on attachment 167983 [details] Patch Clearing flags on attachment: 167983 Committed r130918: <http://trac.webkit.org/changeset/130918>
WebKit Review Bot
Comment 8 2012-10-10 10:11:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.