Bug 98736

Summary: [EFL] duplicate entries in TestExpectations for 'efl' and 'wk2'
Product: WebKit Reporter: Jussi Kukkonen (jku) <jussi.kukkonen>
Component: WebKit EFLAssignee: Jussi Kukkonen (jku) <jussi.kukkonen>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jussi Kukkonen (jku)
Reported 2012-10-09 03:19:11 PDT
We have more port-specific expectations than we really need, that's not good: Quite a few of the efl failure expectation are listed because wk1 failed those tests. After that webkit2 bugs for the same (often totally missing) functionality have been filed and the failures have been listed in the wk2 TestExpectations. For all duplicate lines in wk2 and efl TestExpectations, I'm planning to do this: Remove the expectations from 'efl' TestExpectations and (when it makes sense) add them into 'efl-wk1' TestExpectations.
Attachments
Patch (13.93 KB, patch)
2012-10-09 03:28 PDT, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
Patch (14.11 KB, patch)
2012-10-09 03:41 PDT, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
Patch (14.14 KB, patch)
2012-10-09 04:10 PDT, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jussi Kukkonen (jku)
Comment 1 2012-10-09 03:28:25 PDT
Created attachment 167721 [details] Patch
Jussi Kukkonen (jku)
Comment 2 2012-10-09 03:41:18 PDT
Created attachment 167725 [details] Patch
WebKit Review Bot
Comment 3 2012-10-09 03:59:14 PDT
Comment on attachment 167725 [details] Patch Rejecting attachment 167725 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14207858
Jussi Kukkonen (jku)
Comment 4 2012-10-09 04:10:58 PDT
Created attachment 167729 [details] Patch
WebKit Review Bot
Comment 5 2012-10-09 04:55:00 PDT
Comment on attachment 167729 [details] Patch Clearing flags on attachment: 167729 Committed r130751: <http://trac.webkit.org/changeset/130751>
WebKit Review Bot
Comment 6 2012-10-09 04:55:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.