Summary: | [Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | WebKit Misc. | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, inferno, jamesr, tkent+wkapi, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kent Tamura
2012-10-08 20:44:22 PDT
Created attachment 167679 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. (In reply to comment #2) > Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org Could anyone approve this please? Comment on attachment 167679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167679&action=review API change LGTM > Source/WebKit/chromium/src/WebElement.cpp:70 > + return HTMLNames::xhtmlNamespaceURI == element->namespaceURI() && equalIgnoringCase(element->tagName(), tagName.operator String()); tagName.operator String() -> String(tagName) might be a prettier way to write this. > Could anyone approve this please?
tkent: Given that you're one of our API reviewers, I think it's fine for you to change the API with just a normal review. After all, fishd used to change the API all the time when he was the only API reviewer. :)
Committed r130847: <http://trac.webkit.org/changeset/130847> |