Bug 98695

Summary: Make exporting symbols on Windows less mysterious
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Roger Fong <roger_fong>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, roger_fong, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Windows 2000   
Attachments:
Description Flags
patch none

Simon Fraser (smfr)
Reported 2012-10-08 15:35:57 PDT
After http://trac.webkit.org/changeset/63151, exports from the combined WK1/WK2 dll on windows are controlled by a WebKit2.def file in Source/WebKit2/win/ which is very confusing. This should be cleaned up; I think it would make more sense living in Souce/WebKit or some other directory.
Attachments
patch (264.42 KB, patch)
2013-01-09 15:55 PST, Roger Fong 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2012-10-08 15:43:09 PDT
I'm thinking I'll reorganize things when I do VS2010 stuff, which should be in the near future.
Roger Fong
Comment 2 2013-01-09 12:00:11 PST
bfulgham created an webkitexportgenerator project that use a webkit2.def.in file (later moved changed to webkit.def.in and moved to the webkit folder in http://trac.webkit.org/changeset/138759). Also, see http://trac.webkit.org/wiki/ExportingSymbols
Roger Fong
Comment 3 2013-01-09 15:55:46 PST
Created attachment 182000 [details] patch Changes the name of the definition files so they're easier to find.
Roger Fong
Comment 4 2013-01-09 15:58:38 PST
(In reply to comment #3) > Created an attachment (id=182000) [details] > patch > > Changes the name of the definition files so they're easier to find. VS moved some file orders around in the proj files around to make this patch slightly larger. Wouldn't worry about it though.
Roger Fong
Comment 5 2013-01-09 18:06:12 PST
http://trac.webkit.org/changeset/139259
Jon Lee
Comment 6 2013-01-15 23:55:24 PST
Comment on attachment 182000 [details] patch Remove review flag since this has been checked in.
Note You need to log in before you can comment on or make changes to this bug.