Bug 98681

Summary: Add missing compile flag for compositing
Product: WebKit Reporter: Rik Cabanier <cabanier>
Component: CSSAssignee: Rik Cabanier <cabanier>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98720    
Bug Blocks: 98315    
Attachments:
Description Flags
first try
none
fixed typo
none
I guess you can't do an EWS if the rollout didn't happen yet :-( none

Rik Cabanier
Reported 2012-10-08 12:39:37 PDT
when I enabled compositing on trunk, one of the configuration files was not updated.
Attachments
first try (1.30 KB, patch)
2012-10-08 12:45 PDT, Rik Cabanier 		no flags
DetailsFormatted DiffDiff
fixed typo (1.30 KB, patch)
2012-10-09 09:12 PDT, Rik Cabanier 		no flags
DetailsFormatted DiffDiff
I guess you can't do an EWS if the rollout didn't happen yet :-( (1.30 KB, patch)
2012-10-09 09:29 PDT, Rik Cabanier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rik Cabanier
Comment 1 2012-10-08 12:45:56 PDT
Created attachment 167589 [details] first try
Dirk Schulze
Comment 2 2012-10-08 13:16:15 PDT
Comment on attachment 167589 [details] first try LGTM. r=me
WebKit Review Bot
Comment 3 2012-10-08 13:47:38 PDT
Comment on attachment 167589 [details] first try Clearing flags on attachment: 167589 Committed r130680: <http://trac.webkit.org/changeset/130680>
WebKit Review Bot
Comment 4 2012-10-08 13:47:42 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2012-10-08 22:09:15 PDT
Re-opened since this is blocked by bug 98720
Rik Cabanier
Comment 6 2012-10-09 09:12:52 PDT
Created attachment 167767 [details] fixed typo
Rik Cabanier
Comment 7 2012-10-09 09:29:29 PDT
Created attachment 167772 [details] I guess you can't do an EWS if the rollout didn't happen yet :-(
Zoltan Horvath
Comment 8 2012-10-09 09:48:44 PDT
Comment on attachment 167772 [details] I guess you can't do an EWS if the rollout didn't happen yet :-( It looks good now! I'd r+ it.
Zoltan Horvath
Comment 9 2012-10-09 10:00:02 PDT
Comment on attachment 167772 [details] I guess you can't do an EWS if the rollout didn't happen yet :-( Dirk already review it, relanded with typo fix in: http://trac.webkit.org/changeset/130775
Note You need to log in before you can comment on or make changes to this bug.