Bug 98681 - Add missing compile flag for compositing
Summary: Add missing compile flag for compositing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rik Cabanier
URL:
Keywords:
Depends on: 98720
Blocks: 98315
  Show dependency tree / graph
 
Reported: 2012-10-08 12:39 PDT by Rik Cabanier
Modified: 2012-10-09 10:00 PDT (History)
3 users (show)

See Also:

Attachments
first try (1.30 KB, patch)
2012-10-08 12:45 PDT, Rik Cabanier 		no flags Details | Formatted Diff | Diff
fixed typo (1.30 KB, patch)
2012-10-09 09:12 PDT, Rik Cabanier 		no flags Details | Formatted Diff | Diff
I guess you can't do an EWS if the rollout didn't happen yet :-( (1.30 KB, patch)
2012-10-09 09:29 PDT, Rik Cabanier 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Cabanier 2012-10-08 12:39:37 PDT 
when I enabled compositing on trunk, one of the configuration files was not updated.
Comment 1 Rik Cabanier 2012-10-08 12:45:56 PDT 
Created attachment 167589 [details]
first try
Comment 2 Dirk Schulze 2012-10-08 13:16:15 PDT 
Comment on attachment 167589 [details]
first try

LGTM. r=me
Comment 3 WebKit Review Bot 2012-10-08 13:47:38 PDT 
Comment on attachment 167589 [details]
first try

Clearing flags on attachment: 167589

Committed r130680: <http://trac.webkit.org/changeset/130680>
Comment 4 WebKit Review Bot 2012-10-08 13:47:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2012-10-08 22:09:15 PDT 
Re-opened since this is blocked by bug 98720
Comment 6 Rik Cabanier 2012-10-09 09:12:52 PDT 
Created attachment 167767 [details]
fixed typo
Comment 7 Rik Cabanier 2012-10-09 09:29:29 PDT 
Created attachment 167772 [details]
I guess you can't do an EWS if the rollout didn't happen yet :-(
Comment 8 Zoltan Horvath 2012-10-09 09:48:44 PDT 
Comment on attachment 167772 [details]
I guess you can't do an EWS if the rollout didn't happen yet :-(

It looks good now! I'd r+ it.
Comment 9 Zoltan Horvath 2012-10-09 10:00:02 PDT 
Comment on attachment 167772 [details]
I guess you can't do an EWS if the rollout didn't happen yet :-(

Dirk already review it, relanded with typo fix in: http://trac.webkit.org/changeset/130775