Bug 98663

Summary: [EFL][WK2] EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2012-10-08 10:37:51 PDT
EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing: [ RUN ] EWK2UnitTestBase.ewk_cookie_manager_accept_policy /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:144: Failure Value of: static_cast<char*>(eina_list_nth(hostnames, 0)) Actual: "localhost" Expected: FIRST_PARTY_DOMAIN Which is: "127.0.0.1"
Attachments
Patch (2.06 KB, patch)
2012-10-08 10:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.07 KB, patch)
2012-10-08 11:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-08 10:41:10 PDT
Created attachment 167560 [details] Patch
Laszlo Gombos
Comment 2 2012-10-08 11:13:47 PDT
Comment on attachment 167560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167560&action=review Patch generally looks good. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:119 > +static int sortHostNames(const void* hostName1, const void* hostName2) This function does not really sort. compareHostNames instead ?
Chris Dumez
Comment 3 2012-10-08 11:26:13 PDT
Created attachment 167571 [details] Patch Take Laszlo's feedback into consideration.
Laszlo Gombos
Comment 4 2012-10-08 11:55:44 PDT
Comment on attachment 167571 [details] Patch Thanks. LGTM.
WebKit Review Bot
Comment 5 2012-10-08 13:22:36 PDT
Comment on attachment 167571 [details] Patch Clearing flags on attachment: 167571 Committed r130677: <http://trac.webkit.org/changeset/130677>
WebKit Review Bot
Comment 6 2012-10-08 13:22:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.