EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing: [ RUN ] EWK2UnitTestBase.ewk_cookie_manager_accept_policy /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:144: Failure Value of: static_cast<char*>(eina_list_nth(hostnames, 0)) Actual: "localhost" Expected: FIRST_PARTY_DOMAIN Which is: "127.0.0.1"
Created attachment 167560 [details] Patch
Comment on attachment 167560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167560&action=review Patch generally looks good. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:119 > +static int sortHostNames(const void* hostName1, const void* hostName2) This function does not really sort. compareHostNames instead ?
Created attachment 167571 [details] Patch Take Laszlo's feedback into consideration.
Comment on attachment 167571 [details] Patch Thanks. LGTM.
Comment on attachment 167571 [details] Patch Clearing flags on attachment: 167571 Committed r130677: <http://trac.webkit.org/changeset/130677>
All reviewed patches have been landed. Closing bug.