Bug 98661

Summary: Make all of the WebContext sub objects MessageReceivers
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2012-10-08 10:24:51 PDT
Make all of the WebContext sub objects MessageReceivers
Attachments
Patch (50.90 KB, patch)
2012-10-09 19:58 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (50.98 KB, patch)
2012-10-09 20:44 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (53.84 KB, patch)
2012-10-09 22:13 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-10-09 19:58:40 PDT
Created attachment 167899 [details] Patch
Anders Carlsson
Comment 2 2012-10-09 20:05:18 PDT
Comment on attachment 167899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167899&action=review > Source/WebKit2/ChangeLog:8 > + > + Extra newline.
WebKit Review Bot
Comment 3 2012-10-09 20:10:26 PDT
Attachment 167899 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/WebDatabaseManagerProxy.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 4 2012-10-09 20:35:32 PDT
Comment on attachment 167899 [details] Patch Attachment 167899 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14223971
Sam Weinig
Comment 5 2012-10-09 20:44:53 PDT
Created attachment 167907 [details] Patch
Sam Weinig
Comment 6 2012-10-09 22:13:51 PDT
Created attachment 167920 [details] Patch
WebKit Review Bot
Comment 7 2012-10-10 12:06:55 PDT
Comment on attachment 167920 [details] Patch Clearing flags on attachment: 167920 Committed r130939: <http://trac.webkit.org/changeset/130939>
WebKit Review Bot
Comment 8 2012-10-10 12:06:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.