Summary: | DumpRenderTree should have --pixel-tests option again | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||||
Component: | Tools / Tests | Assignee: | Balazs Kelemen <kbalazs> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dpranke, eric, gyuyoung.kim, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Balazs Kelemen
2012-10-08 06:51:39 PDT
Created attachment 167537 [details]
Patch
Comment on attachment 167537 [details] Patch Attachment 167537 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14201746 Created attachment 167543 [details]
Patch
Why is this useful? Pixel tests require a harness to parse them from the input stream and write out the png files, etc, no? (In reply to comment #4) > Why is this useful? Pixel tests require a harness to parse them from the input stream and write out the png files, etc, no? While that would seem to be true, I have heard the complaint from many people that they miss the flag. I guess maybe they extract the PNGs manually or something? (In reply to comment #5) > (In reply to comment #4) > > Why is this useful? Pixel tests require a harness to parse them from the input stream and write out the png files, etc, no? > > While that would seem to be true, I have heard the complaint from many people that they miss the flag. I guess maybe they extract the PNGs manually or something? I often just check whether it is crashing or not or check if the output is an empty image (this is recognizable from the output). Anyone up to review this? Comment on attachment 167543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167543&action=review Sorry, this must've fallen off my radar :(. > Tools/DumpRenderTree/qt/DumpRenderTreeMain.cpp:69 > +// We only support -v, -p, --pixel-tests, --stdout, --stderr and -, all the others will be -p doesn't actually work, does it? just --pixel-tests? Ideally we'd support -p everywhere as well. (In reply to comment #8) > (From update of attachment 167543 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167543&action=review > > Sorry, this must've fallen off my radar :(. > > > Tools/DumpRenderTree/qt/DumpRenderTreeMain.cpp:69 > > +// We only support -v, -p, --pixel-tests, --stdout, --stderr and -, all the others will be > > -p doesn't actually work, does it? just --pixel-tests? > > Ideally we'd support -p everywhere as well. Landed in http://trac.webkit.org/changeset/133574. I added -p to Qt's DRT and WTR, but I didn't do it for other ports. |