Summary: | Contiguous array allocation should always be inlined | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 97288, 98996, 99196 | ||||||
Bug Blocks: | 99234 | ||||||
Attachments: |
|
Description
Filip Pizlo
2012-10-06 17:43:55 PDT
Created attachment 168488 [details]
the patch
Landed in http://trac.webkit.org/changeset/131249 (In reply to comment #2) > Landed in http://trac.webkit.org/changeset/131249 It broke the 32 bit builds: /ramdisk/qt-linux-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: In member function 'void JSC::DFG::SpeculativeJIT::compile(JSC::DFG::Node&)': /ramdisk/qt-linux-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:3628: error: no matching function for call to 'JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject(JSC::AbstractMacroAssembler<JSC::X86Assembler>::TrustedImmPtr, JSC::DFG::GPRReg&, JSC::DFG::GPRReg&, JSC::DFG::GPRReg&, JSC::AbstractMacroAssembler<JSC::X86Assembler>::JumpList&)'[0m Fix landed in http://trac.webkit.org/changeset/131251 |