Bug 98604

Summary: WTFURL: implement URL port removal for HTMLAnchorElement
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebCore Misc.Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2012-10-06 14:46:57 PDT
Fix the port reset used by HTMLAnchorElement.
Attachments
Patch (12.87 KB, patch)
2012-10-06 15:11 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-10-06 15:11:04 PDT
Created attachment 167461 [details] Patch
Adam Barth
Comment 2 2012-10-07 14:51:01 PDT
Comment on attachment 167461 [details] Patch Ok. I'm slightly worried about the dependency on WTFString.
WebKit Review Bot
Comment 3 2012-10-07 15:01:22 PDT
Comment on attachment 167461 [details] Patch Clearing flags on attachment: 167461 Committed r130609: <http://trac.webkit.org/changeset/130609>
WebKit Review Bot
Comment 4 2012-10-07 15:01:26 PDT
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 5 2012-10-07 15:08:48 PDT
(In reply to comment #2) > Ok. I'm slightly worried about the dependency on WTFString. It is only in ParsedURL, which already depends on WTFString. I have been careful not to push anything in the parser. I added a dependency on LChar in the parser, but I figured we can easily typedef it for use without WTF.
Note You need to log in before you can comment on or make changes to this bug.