Bug 98591

Summary: [EFL][DRT] Switch default backing store to single
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kbalazs, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://lists.webkit.org/pipermail/webkit-efl/2012-October/000316.html
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2012-10-06 02:03:02 PDT
As discussed in webkit-efl mailing list, I think that it is more suitable to use ewk_view_single as a default backing store of DRT. After running pixel-tests in my local, single has 49 image-only regressions and tiled has 54 regressions. Patch will be added.
Attachments
Patch (2.38 KB, patch)
2012-10-07 18:41 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (2.38 KB, patch)
2012-10-07 22:52 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-10-07 18:41:17 PDT
Created attachment 167492 [details] Patch
Ryuan Choi
Comment 2 2012-10-07 22:52:45 PDT
Created attachment 167511 [details] Patch
Eric Seidel (no email)
Comment 3 2012-10-08 11:41:30 PDT
Comment on attachment 167511 [details] Patch rs=me.
WebKit Review Bot
Comment 4 2012-10-08 12:18:31 PDT
Comment on attachment 167511 [details] Patch Clearing flags on attachment: 167511 Committed r130673: <http://trac.webkit.org/changeset/130673>
WebKit Review Bot
Comment 5 2012-10-08 12:18:34 PDT
All reviewed patches have been landed. Closing bug.
Balazs Kelemen
Comment 6 2012-10-09 14:59:53 PDT
By TBS, do you refer some EFL specific thingy or the TBS support in WebKit? In the second case I don't think it's wise to use another backend for testing that you actually ship.
Ryuan Choi
Comment 7 2012-10-09 16:01:11 PDT
(In reply to comment #6) > By TBS, do you refer some EFL specific thingy or the TBS support in WebKit? In the second case I don't think it's wise to use another backend for testing that you actually ship. This is only Efl specific. WebKit1/Efl has used its own TBS (not in WebCore). Tizen had used TBS of WebKit1/Efl but moved to WebKit2/Efl. In case of other Efl applications using WebKit1/Efl such as elm_web and eve, they have used SBS as a default backing store. So, I believe that testing SBS is more reasonable. Thank you.
Note You need to log in before you can comment on or make changes to this bug.