Summary: | Form controls should always be horizontal | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
Component: | Layout and Rendering | Assignee: | Tony Chang <tony> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarcelo, gyuyoung.kim, hyatt, macpherson, menard, morrita, ojan, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tony Chang
2012-10-05 15:31:38 PDT
14:44 < tony^work> dhyatt: The user agent stylesheet (html.css) has some CSS that sets -webkit-block-flow: tb on form elements. Should I just delete that code? 14:45 < dhyatt> oh actually it should turn into writing-mode 14:45 < dhyatt> patch rather than delete 14:45 < dhyatt> writing-mode should reset for form controls 14:45 < tony^work> The writing mode spec seems to suggest we should be able to support vertical controls 14:45 < dhyatt> just as many other props do 14:45 < dhyatt> yes, someday we might support vertical controls 14:46 < dhyatt> but until platforms have that support, we can't just mis-render Created attachment 167398 [details]
Patch
Created attachment 167401 [details]
Patch
Comment on attachment 167401 [details]
Patch
I forgot to add the new -expected.html files.
Comment on attachment 167401 [details] Patch Clearing flags on attachment: 167401 Committed r130569: <http://trac.webkit.org/changeset/130569> All reviewed patches have been landed. Closing bug. |