|Product:||WebKit||Reporter:||WebKit Review Bot <webkit.review.bot>|
|Component:||New Bugs||Assignee:||Adam Barth <abarth>|
|Severity:||Normal||CC:||abarth, buildbot, keishi, rniwa, wangxianzhu|
|Version:||528+ (Nightly build)|
|Bug Depends on:||108166|
Description WebKit Review Bot 2012-10-05 14:36:23 PDT
Re-enable WebFrameTest.DivScrollIntoEditableTest Requested by abarth on #webkit.
Comment 2 Xianzhu Wang 2013-01-28 21:49:59 PST
Created attachment 185154 [details] Patch (comments updated)
Comment 3 Xianzhu Wang 2013-01-28 21:52:08 PST
The original comment above the function read "This test depends on code that is compiled conditionally." I wonder what the macro is and what the original problem was.
Comment 4 Adam Barth 2013-01-28 22:01:40 PST
I don't remember, but re-enabling it is likely to just cause the same failures. Perhaps we should run a try job to try to figure out what the issue was?
Comment 5 Xianzhu Wang 2013-01-28 22:23:01 PST
I modified the test at several places to make it pass in my environment locally (chromium-linux). Will cr-linux ews run webkit_unit_tests?
Comment 6 Adam Barth 2013-01-28 22:23:53 PST
> Will cr-linux ews run webkit_unit_tests? Yes, but only on linux. Do you know if it passes on cr-android as well?
Comment 7 Xianzhu Wang 2013-01-28 22:49:25 PST
Tried the test with the patch on chromium-android. It passed. The tested code is all in WebViewImpl::scrollFocusedNodeIntoRect(). The conditionally compiled code seems not to cause problem now, given that the test has been modified to be consistent with the current code.
Comment 8 Adam Barth 2013-01-28 23:06:22 PST
Comment on attachment 185154 [details] Patch (comments updated) OK. Let's land this and see what happens!
Comment 9 WebKit Review Bot 2013-01-28 23:41:59 PST
Comment on attachment 185154 [details] Patch (comments updated) Clearing flags on attachment: 185154 Committed r141064: <http://trac.webkit.org/changeset/141064>
Comment 10 WebKit Review Bot 2013-01-28 23:42:02 PST
All reviewed patches have been landed. Closing bug.
Comment 12 Keishi Hattori 2013-01-29 01:08:21 PST
Test seems to be failing on WinXP so I am rolling the patch out. http://chromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20XP/builds/2419/steps/webkit_unit_tests/logs/DivScrollIntoEditableTest WebFrameTest.DivScrollIntoEditableTest: tests\WebFrameTest.cpp(974): error: Value of: webView->mainFrame()->scrollOffset().width Actual: 494 Expected: hScroll Which is: 495
Comment 13 Build Bot 2013-01-29 02:59:19 PST
Comment on attachment 185154 [details] Patch (comments updated) Attachment 185154 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16151142 New failing tests: http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
Comment 14 Xianzhu Wang 2013-01-29 09:51:58 PST
Created attachment 185256 [details] Use EXPECT_NEAR to tolerate inaccuracy
Comment 15 Xianzhu Wang 2013-01-29 10:35:56 PST
Comment on attachment 185256 [details] Use EXPECT_NEAR to tolerate inaccuracy Just found that though the changed test passes, it misses a case to test. Will update the patch soon.