Summary: | Remove "orphaned units" quirk | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tab Atkins <tabatkins> | ||||||||
Component: | CSS | Assignee: | Tab Atkins <tabatkins> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cmarcelo, dbarton, dglazkov, eric, gyuyoung.kim, hyatt, kling, koivisto, macpherson, menard, rakuco, robert, simon.fraser, webkit.review.bot, zcorpan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tab Atkins
2012-10-05 13:45:12 PDT
Created attachment 167379 [details]
Patch
Comment on attachment 167379 [details] Patch Attachment 167379 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14169925 New failing tests: WebFrameTest.DivScrollIntoEditableTest touchadjustment/zoom-fatfinger.html fast/css/quirk-orphaned-units.html Comment on attachment 167379 [details] Patch Attachment 167379 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14082046 New failing tests: mathml/presentation/fractions.xhtml fast/css/quirk-orphaned-units.html Created attachment 167434 [details]
Patch
(In reply to comment #4) > Created an attachment (id=167434) [details] > Patch I can't tell how the WebFrameTest or mathml tests were related to this quirk, so I'll let the bots cycle around again and see if the failure is reproducible. I've fixed the other two. Comment on attachment 167434 [details] Patch Attachment 167434 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14182610 New failing tests: mathml/presentation/fractions.xhtml Created attachment 167436 [details]
Patch
(In reply to comment #7) > Created an attachment (id=167436) [details] > Patch All right, found the bug in the mathml test that was depending on this quirk accidentally. Should hopefully go full-green now. Comment on attachment 167436 [details]
Patch
SGTM.
Comment on attachment 167436 [details] Patch Clearing flags on attachment: 167436 Committed r130668: <http://trac.webkit.org/changeset/130668> All reviewed patches have been landed. Closing bug. |