Bug 98553

Summary: Remove "orphaned units" quirk
Product: WebKit Reporter: Tab Atkins <tabatkins>
Component: CSSAssignee: Tab Atkins <tabatkins>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dbarton, dglazkov, eric, gyuyoung.kim, hyatt, kling, koivisto, macpherson, menard, rakuco, robert, simon.fraser, webkit.review.bot, zcorpan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tab Atkins
Reported 2012-10-05 13:45:12 PDT
The "orphaned units" quirk allows things like "width: 20 px;" (note the space between number and unit). This is justified as matching WinIE behavior, but neither FF nor Opera do it, and their devs don't seem to be aware of any bug reports about it. It also wasn't important enough to justify being put into Simon Pieters' Quirks Mode spec <http://dvcs.w3.org/hg/quirks-mode/raw-file/tip/Overview.html>, which was based on surveying browsers and seeing what quirks were needed for web compat. So, I'm removing it.
Attachments
Patch (6.07 KB, patch)
2012-10-05 14:19 PDT, Tab Atkins 		no flags
DetailsFormatted DiffDiff
Patch (68.56 KB, patch)
2012-10-05 18:59 PDT, Tab Atkins 		no flags
DetailsFormatted DiffDiff
Patch (69.26 KB, patch)
2012-10-05 19:39 PDT, Tab Atkins 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tab Atkins
Comment 1 2012-10-05 14:19:58 PDT
Created attachment 167379 [details] Patch
WebKit Review Bot
Comment 2 2012-10-05 15:19:20 PDT
Comment on attachment 167379 [details] Patch Attachment 167379 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14169925 New failing tests: WebFrameTest.DivScrollIntoEditableTest touchadjustment/zoom-fatfinger.html fast/css/quirk-orphaned-units.html
Build Bot
Comment 3 2012-10-05 18:01:36 PDT
Comment on attachment 167379 [details] Patch Attachment 167379 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14082046 New failing tests: mathml/presentation/fractions.xhtml fast/css/quirk-orphaned-units.html
Tab Atkins
Comment 4 2012-10-05 18:59:14 PDT
Created attachment 167434 [details] Patch
Tab Atkins
Comment 5 2012-10-05 19:00:26 PDT
(In reply to comment #4) > Created an attachment (id=167434) [details] > Patch I can't tell how the WebFrameTest or mathml tests were related to this quirk, so I'll let the bots cycle around again and see if the failure is reproducible. I've fixed the other two.
Build Bot
Comment 6 2012-10-05 19:37:35 PDT
Comment on attachment 167434 [details] Patch Attachment 167434 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14182610 New failing tests: mathml/presentation/fractions.xhtml
Tab Atkins
Comment 7 2012-10-05 19:39:58 PDT
Created attachment 167436 [details] Patch
Tab Atkins
Comment 8 2012-10-05 19:40:42 PDT
(In reply to comment #7) > Created an attachment (id=167436) [details] > Patch All right, found the bug in the mathml test that was depending on this quirk accidentally. Should hopefully go full-green now.
Eric Seidel (no email)
Comment 9 2012-10-08 11:52:42 PDT
Comment on attachment 167436 [details] Patch SGTM.
WebKit Review Bot
Comment 10 2012-10-08 12:00:33 PDT
Comment on attachment 167436 [details] Patch Clearing flags on attachment: 167436 Committed r130668: <http://trac.webkit.org/changeset/130668>
WebKit Review Bot
Comment 11 2012-10-08 12:00:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.