Bug 98550

Summary: Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jchaffraix, kling, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98798    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2012-10-05 13:21:38 PDT
Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster
Attachments
Patch (5.07 KB, patch)
2012-10-05 13:24 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-10-05 13:24:29 PDT
Created attachment 167373 [details] Patch
Eric Seidel (no email)
Comment 2 2012-10-05 14:15:17 PDT
Comment on attachment 167373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167373&action=review > Source/WebCore/rendering/AutoTableLayout.cpp:52 > + for (RenderObject* child = m_table->children()->firstChild(); child; child = child->nextSibling()) { For the uninitiated: firstChild() calls virtualChildren()->firstChild(), and is defined on RenderObject. The pointer in question already has a non-virtual children() method which is faster. :)
Andreas Kling
Comment 3 2012-10-05 14:47:45 PDT
Comment on attachment 167373 [details] Patch Nifty! r=me
WebKit Review Bot
Comment 4 2012-10-05 15:08:58 PDT
Comment on attachment 167373 [details] Patch Clearing flags on attachment: 167373 Committed r130560: <http://trac.webkit.org/changeset/130560>
WebKit Review Bot
Comment 5 2012-10-05 15:09:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.