Bug 98524

Summary: [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit2Assignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Patch
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-10-05 08:47:50 PDT
Add support for testrunner.setSerializeHTTPLoads.
Attachments
Patch (9.04 KB, patch)
2012-10-05 09:08 PDT, Sudarsana Nagineni (babu) 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch (9.05 KB, patch)
2012-10-05 09:51 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (8.70 KB, patch)
2012-10-05 14:04 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-10-05 09:08:07 PDT
Created attachment 167334 [details] Patch
Build Bot
Comment 2 2012-10-05 09:12:04 PDT
Comment on attachment 167334 [details] Patch Attachment 167334 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14182440
Build Bot
Comment 3 2012-10-05 09:33:26 PDT
Comment on attachment 167334 [details] Patch Attachment 167334 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14181425
Sudarsana Nagineni (babu)
Comment 4 2012-10-05 09:51:37 PDT
Created attachment 167340 [details] Patch Fixed build issues.
Alexey Proskuryakov
Comment 5 2012-10-05 10:37:04 PDT
Implementation looks 100% right to me. It's confusing that it only fixes two tests. Do you know what's wrong with the other two? I have no objection against landing the patch, but an implementation that doesn't make tests pass is less useful than it could be.
Sudarsana Nagineni (babu)
Comment 6 2012-10-05 14:01:53 PDT
Thanks for reviewing, Alexey. My mistake - I think earlier I tested with some experimental changes locally. Now, I re-tested this and all the corresponding tests are passing. I'm going to update the patch.
Sudarsana Nagineni (babu)
Comment 7 2012-10-05 14:04:30 PDT
Created attachment 167378 [details] Patch
WebKit Review Bot
Comment 8 2012-10-05 16:42:35 PDT
Comment on attachment 167378 [details] Patch Clearing flags on attachment: 167378 Committed r130568: <http://trac.webkit.org/changeset/130568>
WebKit Review Bot
Comment 9 2012-10-05 16:42:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.