Bug 98523

Summary:

[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Tools / Tests

Assignee:

vollick

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, ossy, rakuco, simon.fraser, vollick, webkit.review.bot

Priority:

Keywords:

LayoutTestFailure, MakingBotsRed, Regression

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

URL:

http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r130414%20(1863)/results.html

Attachments:

Description	Flags
Patch	none
Patch	none

Jer Noble

Reported 2012-10-05 08:46:19 PDT

fast/images/repaint-subrect-grid.html started failing on Apple MountainLion Debug WK2 (Tests) between r130412 and r130414 (inclusive). http://trac.webkit.org/log/trunk?rev=130414&stop_rev=130412&limit=4 http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r130411%20(1862)/results.html passed http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r130414%20(1863)/results.html failed Looks like the Mac port needs to add testRunner.displayInvalidatedRegion() support.

Attachments
Patch (23.86 KB, patch) 2012-11-02 07:35 PDT, vollick	no flags	Details Formatted Diff Diff
Patch (23.74 KB, patch) 2012-11-02 07:45 PDT, vollick	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2012-10-05 08:55:58 PDT

Checked in expected failure in r130510.

Simon Fraser (smfr)

Comment 2 2012-11-01 16:11:44 PDT

We should remove testRunner.displayInvalidatedRegion(), and eventually display() too.

vollick

Comment 3 2012-11-02 07:35:48 PDT

Created attachment 172059 [details] Patch

vollick

Comment 4 2012-11-02 07:45:20 PDT

Created attachment 172060 [details] Patch Sorry for the extra patch. I'd left some unnecessary lines in the test that are no longer needed now that text-based-repaint.js is driving things.

Simon Fraser (smfr)

Comment 5 2012-11-02 09:00:53 PDT

Comment on attachment 172060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172060&action=review > LayoutTests/ChangeLog:9 > + The repaint-subrect-grid.html layout test is now text-based and > + doesn't use testRunner.displayInvalidatedRegion(). Is this the only test that used displayInvalidatedRegion()?

WebKit Review Bot

Comment 6 2012-11-02 11:45:31 PDT

Comment on attachment 172060 [details] Patch Clearing flags on attachment: 172060 Committed r133322: <http://trac.webkit.org/changeset/133322>

WebKit Review Bot

Comment 7 2012-11-02 11:45:36 PDT

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 8 2012-11-04 02:28:48 PST

(In reply to comment #6) > (From update of attachment 172060 [details]) > Clearing flags on attachment: 172060 > > Committed r133322: <http://trac.webkit.org/changeset/133322> The unskipped test fails on Qt: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r133416%20%2844686%29/fast/images/repaint-subrect-grid-pretty-diff.html Could you check if this result is correct or not? I don't know anything about how this test works and what this coordinates mean.

Note You need to log in before you can comment on or make changes to this bug.