Bug 98519

Summary: [EFL] Build ControlTheme only when necessary
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2012-10-05 08:08:03 PDT
Now, ControlTheme is always compiled after introduced. Patch will be added.
Attachments
Patch (1.50 KB, patch)
2012-10-05 08:19 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.52 KB, patch)
2012-10-08 16:26 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-10-05 08:19:43 PDT
Created attachment 167329 [details] Patch
Eric Seidel (no email)
Comment 2 2012-10-08 11:54:19 PDT
Comment on attachment 167329 [details] Patch rs=me.
WebKit Review Bot
Comment 3 2012-10-08 16:21:50 PDT
Comment on attachment 167329 [details] Patch Rejecting attachment 167329 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14228387
Ryuan Choi
Comment 4 2012-10-08 16:26:05 PDT
Created attachment 167639 [details] Patch
Ryuan Choi
Comment 5 2012-10-08 16:27:03 PDT
Comment on attachment 167639 [details] Patch rebased because of weird error.
WebKit Review Bot
Comment 6 2012-10-08 17:59:09 PDT
Comment on attachment 167639 [details] Patch Clearing flags on attachment: 167639 Committed r130707: <http://trac.webkit.org/changeset/130707>
WebKit Review Bot
Comment 7 2012-10-08 17:59:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.