Bug 98519 - [EFL] Build ControlTheme only when necessary
Summary: [EFL] Build ControlTheme only when necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-05 08:08 PDT by Ryuan Choi
Modified: 2012-10-08 17:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2012-10-05 08:19 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2012-10-08 16:26 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-10-05 08:08:03 PDT 
Now, ControlTheme is always compiled after introduced.
Patch will be added.
Comment 1 Ryuan Choi 2012-10-05 08:19:43 PDT 
Created attachment 167329 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-08 11:54:19 PDT 
Comment on attachment 167329 [details]
Patch

rs=me.
Comment 3 WebKit Review Bot 2012-10-08 16:21:50 PDT 
Comment on attachment 167329 [details]
Patch

Rejecting attachment 167329 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14228387
Comment 4 Ryuan Choi 2012-10-08 16:26:05 PDT 
Created attachment 167639 [details]
Patch
Comment 5 Ryuan Choi 2012-10-08 16:27:03 PDT 
Comment on attachment 167639 [details]
Patch

rebased because of weird error.
Comment 6 WebKit Review Bot 2012-10-08 17:59:09 PDT 
Comment on attachment 167639 [details]
Patch

Clearing flags on attachment: 167639

Committed r130707: <http://trac.webkit.org/changeset/130707>
Comment 7 WebKit Review Bot 2012-10-08 17:59:12 PDT 
All reviewed patches have been landed.  Closing bug.