Bug 98513

Summary: SVG classes cause layering violations in platform Font code
Product: WebKit Reporter: Stephen Chenney <schenney>
Component: PlatformAssignee: Stephen Chenney <schenney>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, eric, fmalita, mitz, pdr, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephen Chenney
Reported 2012-10-05 06:33:57 PDT
The WebCore::FontFallbackList header refers to SVG classes as friends. This is a layering violation and can be fixed by making the APIs public in some way.
Attachments
Patch (5.73 KB, patch)
2012-11-01 15:07 PDT, Stephen Chenney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephen Chenney
Comment 1 2012-11-01 15:07:29 PDT
Created attachment 171942 [details] Patch
Eric Seidel (no email)
Comment 2 2012-11-01 15:12:05 PDT
Comment on attachment 171942 [details] Patch Much nicer.
Stephen Chenney
Comment 3 2012-11-01 18:37:18 PDT
Test failures might be real. I'll have to look at it.
Stephen Chenney
Comment 4 2012-11-02 06:01:31 PDT
Comment on attachment 171942 [details] Patch Let's try again.
WebKit Review Bot
Comment 5 2012-11-02 06:34:20 PDT
Comment on attachment 171942 [details] Patch Clearing flags on attachment: 171942 Committed r133290: <http://trac.webkit.org/changeset/133290>
WebKit Review Bot
Comment 6 2012-11-02 06:34:24 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2012-11-02 15:59:25 PDT
Comment on attachment 171942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171942&action=review > Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:191 > + // Save data fromt he font fallback list because we may modify it later. Do this before the Typo here, "fromt he"
Note You need to log in before you can comment on or make changes to this bug.