Summary: | [EFL][WK2] ewk_web_error_free is not a public API | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||||||
Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ryuan Choi
2012-10-04 22:01:42 PDT
Agreed. Thanks. Created attachment 167249 [details]
Patch
Comment on attachment 167249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167249&action=review > Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:-55 > - * Frees the given object. This doc should probably be moved to the cpp file with a @internal tag. Created attachment 167253 [details]
Patch
(In reply to comment #3) > (From update of attachment 167249 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167249&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:-55 > > - * Frees the given object. > > This doc should probably be moved to the cpp file with a @internal tag. OK, moved. Comment on attachment 167253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167253&action=review > Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp:72 > + * Frees the give object. "given" Created attachment 167254 [details]
Patch
(In reply to comment #6) > (From update of attachment 167253 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167253&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp:72 > > + * Frees the give object. > > "given" mistake. fixed. Thank you. Comment on attachment 167254 [details]
Patch
LGTM. Thanks.
Comment on attachment 167254 [details] Patch Clearing flags on attachment: 167254 Committed r130470: <http://trac.webkit.org/changeset/130470> All reviewed patches have been landed. Closing bug. |