Bug 98479

Summary: Add appearance tests for input[type=date] with multiple fields
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98226    
Attachments:
Description Flags
Patch
none
Patch 2 haraken: review+

Kent Tamura
Reported 2012-10-04 21:47:59 PDT
Add appearance tests for input[type=date] with multiple fields
Attachments
Patch (101.20 KB, patch)
2012-10-05 00:24 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (103.89 KB, patch)
2012-10-05 00:52 PDT, Kent Tamura 		haraken: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-10-05 00:24:18 PDT
Created attachment 167268 [details] Patch
Yuta Kitamura
Comment 2 2012-10-05 00:33:15 PDT
Comment on attachment 167268 [details] Patch Looks fine.
Kentaro Hara
Comment 3 2012-10-05 00:33:41 PDT
Comment on attachment 167268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167268&action=review > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html:25 > +<script> Nit: (Although I don't know the convention of forms tests,) it looks a bit strange to put <script> after </body>. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html:26 > +if (window.testRunner) { Nit: {} is not needed. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:16 > +<script> Ditto. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:17 > +if (window.testRunner) { Ditto. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html:11 > +<script> Ditto. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html:12 > +if (window.testRunner) { Ditto.
Yuta Kitamura
Comment 4 2012-10-05 00:38:42 PDT
Comment on attachment 167268 [details] Patch Hm, I agree with haraken. Sounds like these points need to be fixed.
Kent Tamura
Comment 5 2012-10-05 00:52:23 PDT
Created attachment 167272 [details] Patch 2 Fix scripts
Kent Tamura
Comment 6 2012-10-05 00:58:30 PDT
Committed r130480: <http://trac.webkit.org/changeset/130480>
Note You need to log in before you can comment on or make changes to this bug.