Summary: | Add appearance tests for input[type=date] with multiple fields | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Tools / Tests | Assignee: | Kent Tamura <tkent> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | haraken, morrita, yutak | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 98226 | ||||||||
Attachments: |
|
Description
Kent Tamura
2012-10-04 21:47:59 PDT
Created attachment 167268 [details]
Patch
Comment on attachment 167268 [details]
Patch
Looks fine.
Comment on attachment 167268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167268&action=review > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html:25 > +<script> Nit: (Although I don't know the convention of forms tests,) it looks a bit strange to put <script> after </body>. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html:26 > +if (window.testRunner) { Nit: {} is not needed. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:16 > +<script> Ditto. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:17 > +if (window.testRunner) { Ditto. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html:11 > +<script> Ditto. > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html:12 > +if (window.testRunner) { Ditto. Comment on attachment 167268 [details]
Patch
Hm, I agree with haraken. Sounds like these points need to be fixed.
Created attachment 167272 [details]
Patch 2
Fix scripts
Committed r130480: <http://trac.webkit.org/changeset/130480> |