Bug 98479

Summary: Add appearance tests for input[type=date] with multiple fields
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98226    
Attachments:
Description Flags
Patch
none
Patch 2 haraken: review+

Description Kent Tamura 2012-10-04 21:47:59 PDT
Add appearance tests for input[type=date] with multiple fields
Comment 1 Kent Tamura 2012-10-05 00:24:18 PDT
Created attachment 167268 [details]
Patch
Comment 2 Yuta Kitamura 2012-10-05 00:33:15 PDT
Comment on attachment 167268 [details]
Patch

Looks fine.
Comment 3 Kentaro Hara 2012-10-05 00:33:41 PDT
Comment on attachment 167268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167268&action=review

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html:25
> +<script>

Nit: (Although I don't know the convention of forms tests,) it looks a bit strange to put <script> after </body>.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html:26
> +if (window.testRunner) {

Nit: {} is not needed.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:16
> +<script>

Ditto.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:17
> +if (window.testRunner) {

Ditto.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html:11
> +<script>

Ditto.

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html:12
> +if (window.testRunner) {

Ditto.
Comment 4 Yuta Kitamura 2012-10-05 00:38:42 PDT
Comment on attachment 167268 [details]
Patch

Hm, I agree with haraken. Sounds like these points need to be fixed.
Comment 5 Kent Tamura 2012-10-05 00:52:23 PDT
Created attachment 167272 [details]
Patch 2

Fix scripts
Comment 6 Kent Tamura 2012-10-05 00:58:30 PDT
Committed r130480: <http://trac.webkit.org/changeset/130480>