Bug 98478

Summary: Fix font for date/time input types.
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, haraken, macpherson, menard, morrita, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98226    
Attachments:
Description Flags
Patch
none
Patch 2 none

Description Kent Tamura 2012-10-04 21:46:46 PDT 
* input[type=date] should use monospace font
* input[type=datetime/datetime-local/time/week/month] should not use monospace font if the type is disabled.
Comment 1 Kent Tamura 2012-10-04 22:01:27 PDT 
Created attachment 167245 [details]
Patch
Comment 2 Kent Tamura 2012-10-04 22:05:52 PDT 
Created attachment 167246 [details]
Patch 2

Update ChangeLog
Comment 3 Kentaro Hara 2012-10-04 22:07:41 PDT 
Comment on attachment 167246 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=167246&action=review

> Source/WebCore/ChangeLog:17
> +        The input[type=date] change is covered by
> +        fast/forms/date/calendar-picker-appearance.html,
> +        platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html

Why isn't there any change in these test results although you're changing fonts in this patch? Such a minor change is not detected?
Comment 4 Kent Tamura 2012-10-04 22:10:02 PDT 
Comment on attachment 167246 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=167246&action=review

>> Source/WebCore/ChangeLog:17
>> +        platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html
> 
> Why isn't there any change in these test results although you're changing fonts in this patch? Such a minor change is not detected?

Fortunately these tests are suppressed in TestExpectations for now because they need rebaseline by prior changes.
Comment 5 Kentaro Hara 2012-10-04 22:10:49 PDT 
Comment on attachment 167246 [details]
Patch 2

OK. Please just confirm the appearance manually.
Comment 6 WebKit Review Bot 2012-10-04 23:24:48 PDT 
Comment on attachment 167246 [details]
Patch 2

Clearing flags on attachment: 167246

Committed r130467: <http://trac.webkit.org/changeset/130467>
Comment 7 WebKit Review Bot 2012-10-04 23:24:51 PDT 
All reviewed patches have been landed.  Closing bug.