Bug 98473

Summary:

SVGAttributeHashTranslator does not need to copy QualifiedName in the common case

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, fmalita, pdr, schenney, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

98467

Attachments:

Description	Flags
Patch	none
Patch	none

Description Eric Seidel (no email) 2012-10-04 18:51:53 PDT

SVGAttributeHashTranslator does not need to copy QualifiedName in the common case

Comment 1 Eric Seidel (no email) 2012-10-04 18:52:07 PDT

Created attachment 167220 [details]
Patch

Comment 2 Eric Seidel (no email) 2012-10-04 18:52:44 PDT

This makes SVG animation (and anything that changes SVG attributes) much slower than necessary.

Comment 3 Eric Seidel (no email) 2012-10-04 18:53:36 PDT

I found this while working on another bug.  I sampled my test case and found this code to be super-hot.  This patch made the most of the samples in this area go away. :)

Comment 4 Eric Seidel (no email) 2012-10-04 18:56:13 PDT

Created attachment 167222 [details]
Patch

Comment 5 WebKit Review Bot 2012-10-04 21:22:22 PDT

Comment on attachment 167222 [details]
Patch

Clearing flags on attachment: 167222

Committed r130456: <http://trac.webkit.org/changeset/130456>

Comment 6 WebKit Review Bot 2012-10-04 21:22:25 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Darin Adler 2012-10-05 17:14:52 PDT

Oh my god! Good one.