Bug 98469

Summary: [Refactoring] Some classes in StyleResolver.cpp/h could have its own file.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: CSSAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, gyuyoung.kim, koivisto, macpherson, menard, rakuco, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98244    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Hajime Morrita
Reported 2012-10-04 17:38:31 PDT
This spinned out from Bug 98244. RuleSet, RuleData, RuleFeature and Features can own its own file.
Attachments
Patch (56.41 KB, patch)
2012-10-04 19:23 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (65.69 KB, patch)
2012-10-04 19:56 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (65.69 KB, patch)
2012-10-04 21:17 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-10-04 19:23:05 PDT
Created attachment 167230 [details] Patch
Hajime Morrita
Comment 2 2012-10-04 19:56:33 PDT
Created attachment 167237 [details] Patch
Early Warning System Bot
Comment 3 2012-10-04 20:16:00 PDT
Comment on attachment 167237 [details] Patch Attachment 167237 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14168571
Hajime Morrita
Comment 4 2012-10-04 21:17:11 PDT
Created attachment 167242 [details] Patch
Dimitri Glazkov (Google)
Comment 5 2012-10-04 21:22:06 PDT
Comment on attachment 167242 [details] Patch please make sure it builds before landing.
Hajime Morrita
Comment 6 2012-10-04 21:25:35 PDT
> (From update of attachment 167242 [details]) > please make sure it builds before landing. Thanks for quick r+. I'm waiting for the greenness.
WebKit Review Bot
Comment 7 2012-10-04 23:15:12 PDT
Comment on attachment 167242 [details] Patch Clearing flags on attachment: 167242 Committed r130465: <http://trac.webkit.org/changeset/130465>
WebKit Review Bot
Comment 8 2012-10-04 23:15:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.