Bug 98459

Summary: [Chromium] Improve SocketStreamHandle::send() stability
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: WebCore Misc.Assignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kenichi Ishibashi
Reported 2012-10-04 16:00:40 PDT
It's not often, but it seems that m_socket can be null in SocketStreamHandle::send(). It should not be NULL there, but for stability, we are going to add a null check. See http://code.google.com/p/chromium/issues/detail?id=153440 more details.
Attachments
Patch (1.78 KB, patch)
2012-10-04 16:06 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-10-04 16:06:25 PDT
Created attachment 167195 [details] Patch
Yuta Kitamura
Comment 2 2012-10-04 19:17:11 PDT
Comment on attachment 167195 [details] Patch Looks OK.
Kenichi Ishibashi
Comment 3 2012-10-04 19:22:24 PDT
Comment on attachment 167195 [details] Patch Thank you for review!
WebKit Review Bot
Comment 4 2012-10-04 20:57:35 PDT
Comment on attachment 167195 [details] Patch Rejecting attachment 167195 [details] from commit-queue. New failing tests: fast/images/paint-subrect-grid.html Full output: http://queues.webkit.org/results/14176352
WebKit Review Bot
Comment 5 2012-10-04 23:39:11 PDT
Comment on attachment 167195 [details] Patch Clearing flags on attachment: 167195 Committed r130468: <http://trac.webkit.org/changeset/130468>
WebKit Review Bot
Comment 6 2012-10-04 23:39:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.