Bug 98454

Summary: Split the intrinsic padding update code out of RenderTableSection::layoutRows
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: TablesAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, eric, hyatt, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed split. Cleaned up a little layoutRows while touching it. none

Description Julien Chaffraix 2012-10-04 15:13:44 PDT 
RenderTableSection::layoutRows is very long and it's difficult to see what's going on.

The idea of this bug is to split the part about setting the cell's intrinsic padding and move it to RenderTableCell as there is little dependency on RenderTableSection.

Patch forthcoming.
Comment 1 Eric Seidel (no email) 2012-10-04 15:15:51 PDT 
And how!
Comment 2 Julien Chaffraix 2012-10-04 15:36:58 PDT 
Created attachment 167189 [details]
Proposed split. Cleaned up a little layoutRows while touching it.
Comment 3 Eric Seidel (no email) 2012-10-04 19:41:13 PDT 
Comment on attachment 167189 [details]
Proposed split. Cleaned up a little layoutRows while touching it.

Fantastic. :)
Comment 4 WebKit Review Bot 2012-10-04 21:10:15 PDT 
Comment on attachment 167189 [details]
Proposed split. Cleaned up a little layoutRows while touching it.

Clearing flags on attachment: 167189

Committed r130454: <http://trac.webkit.org/changeset/130454>
Comment 5 WebKit Review Bot 2012-10-04 21:10:19 PDT 
All reviewed patches have been landed.  Closing bug.