Bug 98431

Summary:

JSC should have a way to gather and log Heap memory use and pause times

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, gyuyoung.kim, philn, rakuco, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Mark Hahnenberg

Reported 2012-10-04 11:21:31 PDT

In order to improve our infrastructure for benchmark-driven development, we should have a centralized method of gathering and logging various statistics about the state of the JS heap. This would allow us to create and to use other tools to analyze the output of the VM after running various workloads. The first two statistics that might be interesting is memory use by JSC and GC pause times. We can control whether this recording happens through the use of the Options class, allowing us to either use environment variables or command line flags.

Attachments
Patch (28.32 KB, patch) 2012-10-04 11:37 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (30.61 KB, patch) 2012-10-04 12:11 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (29.79 KB, patch) 2012-10-04 13:49 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (30.34 KB, patch) 2012-10-04 15:14 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (30.28 KB, patch) 2012-10-04 16:33 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (31.00 KB, patch) 2012-10-04 18:55 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2012-10-04 11:37:17 PDT

Created attachment 167148 [details] Patch

WebKit Review Bot

Comment 2 2012-10-04 11:40:44 PDT

Attachment 167148 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/Options.h:178: size_tVal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Hahnenberg

Comment 3 2012-10-04 12:11:52 PDT

Created attachment 167155 [details] Patch

WebKit Review Bot

Comment 4 2012-10-04 12:13:51 PDT

Attachment 167155 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/Options.h:178: size_tVal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 5 2012-10-04 12:55:03 PDT

Comment on attachment 167155 [details] Patch Attachment 167155 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14180136

Early Warning System Bot

Comment 6 2012-10-04 12:57:45 PDT

Comment on attachment 167155 [details] Patch Attachment 167155 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14152623

Build Bot

Comment 7 2012-10-04 13:20:24 PDT

Comment on attachment 167155 [details] Patch Attachment 167155 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14182088

Build Bot

Comment 8 2012-10-04 13:30:00 PDT

Comment on attachment 167155 [details] Patch Attachment 167155 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14173275