Bug 98401
| Summary: | Compile PLUGIN_PROCESS code only when NETSCAPE_PLUGIN_API macro is on | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mariusz Grzegorczyk <mariusz.g> |
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | aestes, bfulgham, cdumez, cgarcia, csaavedra, laszlo.gombos, mrobinson, philip.chimento, rakuco |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mariusz Grzegorczyk
In webkit2 there are some places where code related with plugin process is guarded by only PLUGIN_PROCESS macro, and in other places with both PLUGIN_PROCESS and NETSCAPE_PLUGIN_API.
Following commit tries to make some cleanup:
"Guard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API)
https://bugs.webkit.org/show_bug.cgi?id=86496"
Files like UIProcess/Plugins/PluginProcessProxy.cpp are being taken to compile always, and inside them at the beginning there is #if ENABLE(PLUGIN_PROCESS) guard. I think that in all places also NETSCAPE_PLUGIN_API check should be added. If plugins are off PLUGIN_PROCESS's code shouldn't be compiled.
Other example:
PluginProxyQt.cpp has guard #if ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API), while
PluginProxy.h only #if ENABLE(PLUGIN_PROCESS)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Claudio Saavedra
This is related to 89451, probably a duplicate.
Philip Chimento
Duplicate of https://bugs.webkit.org/show_bug.cgi?id=98262 I think?
Carlos Garcia Campos
(In reply to comment #2)
> Duplicate of https://bugs.webkit.org/show_bug.cgi?id=98262 I think?
No it's not, if ENABLE_PLUGIN_PROCESS was false when ENABLE_NETSCAPE_PLUGIN_API is false you wouldn't need most of the #ifdefs you are adding in bug #98262
Brent Fulgham
WebKit no longer support NPAPI plugins.