Bug 98387

Summary: [Qt] GL_ARB_texture_rectangle must be activated when using ANGLE on Mac.
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: WebKit2Assignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch for review.
noam: review-
patch for review. - using Extensions3D. none

Zeno Albisser
Reported 2012-10-04 02:26:14 PDT
The GraphicsSurface implementation on Mac is based on an IOSurface. And IOSurface requires this extension. So this change is necessary to enable WebGL again after r127063.
Attachments
patch for review. (1.54 KB, patch)
2012-10-04 02:37 PDT, Zeno Albisser 		noam: review-
DetailsFormatted DiffDiff
patch for review. - using Extensions3D. (1.60 KB, patch)
2012-10-05 04:58 PDT, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2012-10-04 02:37:38 PDT
Created attachment 167059 [details] patch for review.
Noam Rosenthal
Comment 2 2012-10-04 07:14:24 PDT
Comment on attachment 167059 [details] patch for review. View in context: https://bugs.webkit.org/attachment.cgi?id=167059&action=review > Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:211 > + if (m_platformContext->hasExtension(QByteArrayLiteral("GL_ARB_texture_rectangle"))) > + ANGLEResources.ARB_texture_rectangle = 1; Please use Extensions3D
Zeno Albisser
Comment 3 2012-10-05 04:58:27 PDT
Created attachment 167309 [details] patch for review. - using Extensions3D.
Zeno Albisser
Comment 4 2012-10-10 03:38:36 PDT
Comment on attachment 167309 [details] patch for review. - using Extensions3D. Clearing flags on attachment: 167309 Committed r130880: <http://trac.webkit.org/changeset/130880>
Zeno Albisser
Comment 5 2012-10-10 03:38:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.