Bug 98387

Summary: [Qt] GL_ARB_texture_rectangle must be activated when using ANGLE on Mac.
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: WebKit2Assignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch for review.
noam: review-
patch for review. - using Extensions3D. none

Description Zeno Albisser 2012-10-04 02:26:14 PDT 
The GraphicsSurface implementation on Mac is based on an IOSurface.
And IOSurface requires this extension.
So this change is necessary to enable WebGL again after r127063.
Comment 1 Zeno Albisser 2012-10-04 02:37:38 PDT 
Created attachment 167059 [details]
patch for review.
Comment 2 Noam Rosenthal 2012-10-04 07:14:24 PDT 
Comment on attachment 167059 [details]
patch for review.

View in context: https://bugs.webkit.org/attachment.cgi?id=167059&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:211
> +    if (m_platformContext->hasExtension(QByteArrayLiteral("GL_ARB_texture_rectangle")))
> +        ANGLEResources.ARB_texture_rectangle = 1;

Please use Extensions3D
Comment 3 Zeno Albisser 2012-10-05 04:58:27 PDT 
Created attachment 167309 [details]
patch for review. - using Extensions3D.
Comment 4 Zeno Albisser 2012-10-10 03:38:36 PDT 
Comment on attachment 167309 [details]
patch for review. - using Extensions3D.

Clearing flags on attachment: 167309

Committed r130880: <http://trac.webkit.org/changeset/130880>
Comment 5 Zeno Albisser 2012-10-10 03:38:42 PDT 
All reviewed patches have been landed.  Closing bug.