Bug 98385 – Web Inspector: When uiSourceCode content has diverged from VM script, call frames should be shown in temporary script based uiSourceCodes.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Vsevolod Vlasov]

Patch to follow

[Vsevolod Vlasov]

Created attachment 167053 [details]
Patch

[Vsevolod Vlasov]

Created attachment 167055 [details]
Patch

[Pavel Feldman]

Comment on attachment 167055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167055&action=review

> Source/WebCore/ChangeLog:8
> +        Introduced uiSourceCode attribute concept and attributeChanged event.

Please split this change, it has too many random components.

> Source/WebCore/inspector/front-end/DebuggerModel.js:779
> +        return this._script.rawLocationToUILocation(this.location.lineNumber, this.location.columnNumber);

I think we should either expose live locations or location getters.

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:163
> +        var breakpoints = this._getBreakpointDecorations();

This is quite expensive (you are doing it per key press, right?)
no _get prefixes in WebKit

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:172
> +            this._setBreakpointDecorations(breakpoints);

You should instead get breakpoints from the vm version of UISourceCode.

[Vsevolod Vlasov]

Created attachment 167107 [details]
Patch

[Pavel Feldman]

Comment on attachment 167107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167107&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:112
> +        if (uiSourceCode.isDivergedReplacement)

divergedVersion: function()
{
    return uiSourceCode;
}

> Source/WebCore/inspector/front-end/JavaScriptSource.js:80
> +    fireHasDivergedFromVMChanged: function()

I would split it into "fileHasDiverged" and "fileWasMerged"

[Vsevolod Vlasov]

Committed r130393: <http://trac.webkit.org/changeset/130393>