Summary: | [WK2][GTK][EFL] standard_output returned by g_spawn_sync must be freed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sudarsana Nagineni (babu) <naginenis> | ||||||
Component: | WebKit EFL | Assignee: | Sudarsana Nagineni (babu) <naginenis> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, laszlo.gombos, lucas.de.marchi, mariusz.g, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sudarsana Nagineni (babu)
2012-10-04 01:06:57 PDT
Created attachment 167044 [details]
Patch
Comment on attachment 167044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167044&action=review > Source/WebKit2/ChangeLog:3 > + [WK2] [EFL] standard_output returned by g_spawn_sync must be freed This is not EFL port patch. Please remove [EFL] keyword. > Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:68 > + free(stdOut); Don't we need to check if stdOut is null once more? Comment on attachment 167044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167044&action=review >> Source/WebKit2/ChangeLog:3 >> + [WK2] [EFL] standard_output returned by g_spawn_sync must be freed > > This is not EFL port patch. Please remove [EFL] keyword. This code is under GTK/EFL ifdef guards. I think make sense to add GTK too, instead of removing EFL. >> Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:68 >> + free(stdOut); > > Don't we need to check if stdOut is null once more? free is NULL-safe, no need to check. Created attachment 167278 [details]
Patch
Updated changelog.
Comment on attachment 167278 [details]
Patch
Looks make sense.
Comment on attachment 167278 [details] Patch Clearing flags on attachment: 167278 Committed r130490: <http://trac.webkit.org/changeset/130490> All reviewed patches have been landed. Closing bug. |