Summary: | [GTK] accessibility/editable-webarea-context-menu-point.html is failing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
Component: | WebKitGTK | Assignee: | Joanmarie Diggs <jdiggs> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apinheiro, cfleizach, dmazzoni, jdiggs, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Gtk, LayoutTestFailure | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 98347 | ||||||||
Attachments: |
|
Description
Zan Dobersek
2012-10-04 00:39:00 PDT
Definitely will require implementing AccessibilityUIElement::clickPointX(). Whether or not that will be sufficient to make this test pass remains to be seen. Created attachment 178410 [details]
Patch
Chris: This patch just moves the failing test to the Mac platform as it seems to be mac-specific. I already checked with Mario and he agrees. Please review. Thanks in advance! Comment on attachment 178410 [details] Patch Attachment 178410 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15222297 New failing tests: platform/mac/accessibility/editable-webarea-context-menu-point.html I'm assuming that the failure on the mac is due to the fact that I'm moving the test, rather than a real failure.(?) Created attachment 178414 [details]
Patch
Comment on attachment 178414 [details]
Patch
click point on the mac is just the center point of the bounding box. maybe there's something else that makes that hard to get to
Comment on attachment 178414 [details] Patch Clearing flags on attachment: 178414 Committed r137113: <http://trac.webkit.org/changeset/137113> All reviewed patches have been landed. Closing bug. (In reply to comment #7) > (From update of attachment 178414 [details]) > click point on the mac is just the center point of the bounding box. maybe there's something else that makes that hard to get to Aha! I didn't know about the bounding box. Bounding boxes I can get and center point I can calculate. Not sure if that makes this patch rollout-worthy.... |