Bug 98335

Summary: Use copyLCharsFromUCharSource() for IdentifierLCharFromUCharTranslator translation
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: JavaScriptCoreAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2012-10-03 18:03:44 PDT
Let's use the optimized version :)
Attachments
Patch (1.83 KB, patch)
2012-10-03 18:11 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-10-03 18:11:42 PDT
Created attachment 167014 [details] Patch
Benjamin Poulain
Comment 2 2012-10-04 12:34:13 PDT
Comment on attachment 167014 [details] Patch Clearing flags on attachment: 167014 Committed r130418: <http://trac.webkit.org/changeset/130418>
Benjamin Poulain
Comment 3 2012-10-04 12:34:15 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2012-10-04 14:37:32 PDT
It’s kind of bad that copyLCharsFromUCharSource is in ASCIIFastPath.h, because LChar allows non-ASCII characters. The header may need a new name or something.
Darin Adler
Comment 5 2012-10-04 14:37:58 PDT
Comment on attachment 167014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167014&action=review > Source/JavaScriptCore/runtime/Identifier.cpp:84 > + WTF::copyLCharsFromUCharSource(d, buf.s, buf.length); The explicit WTF here is strange, and should not be needed if ASCIIFastPath follows the normal using model we use for WTF headers.
Note You need to log in before you can comment on or make changes to this bug.