Bug 98327

Summary:

Simplify attribute access in Element::computeInheritedLanguage

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

DOM

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, dglazkov, gustavo, philn, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Benjamin Poulain

Reported 2012-10-03 16:43:48 PDT

Small optimization.

Attachments
Patch (2.39 KB, patch) 2012-10-03 16:49 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (2.38 KB, patch) 2012-10-03 17:32 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2012-10-03 16:49:51 PDT

Created attachment 166993 [details] Patch

Andreas Kling

Comment 2 2012-10-03 16:53:41 PDT

Comment on attachment 166993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166993&action=review r=me, though I suspect you could save a couple more cycles here by doing a custom loop over the attributeData->attributeItem()s. > Source/WebCore/dom/Element.cpp:1762 > + ElementAttributeData* attributeData = static_cast<const Element*>(n)->attributeData(); > + if (attributeData) { Scope 'attributeData' to the if.

Gyuyoung Kim

Comment 3 2012-10-03 17:03:17 PDT

Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14123896

Build Bot

Comment 4 2012-10-03 17:06:21 PDT

Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14126975

Early Warning System Bot

Comment 5 2012-10-03 17:07:16 PDT

Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14125978

WebKit Review Bot

Comment 6 2012-10-03 17:17:46 PDT

Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14129849