Summary: | Simplify attribute access in Element::computeInheritedLanguage | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
Component: | DOM | Assignee: | Benjamin Poulain <benjamin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarcelo, dglazkov, gustavo, philn, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Benjamin Poulain
2012-10-03 16:43:48 PDT
Created attachment 166993 [details]
Patch
Comment on attachment 166993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166993&action=review r=me, though I suspect you could save a couple more cycles here by doing a custom loop over the attributeData->attributeItem()s. > Source/WebCore/dom/Element.cpp:1762 > + ElementAttributeData* attributeData = static_cast<const Element*>(n)->attributeData(); > + if (attributeData) { Scope 'attributeData' to the if. Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14123896 Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14126975 Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14125978 Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14129849 Comment on attachment 166993 [details] Patch Attachment 166993 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14138773 Created attachment 167006 [details]
Patch
Comment on attachment 167006 [details] Patch Clearing flags on attachment: 167006 Committed r130354: <http://trac.webkit.org/changeset/130354> All reviewed patches have been landed. Closing bug. |