Bug 98301

Summary: Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: aa, abecsi, eric, gtk-ews, gustavo, gyuyoung.kim, mjs, mrobinson, ojan, rakuco, roger_fong, vestbo, webkit.review.bot, xan.lopez, yurys
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Adam Barth
Reported 2012-10-03 14:17:30 PDT
Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER)
Attachments
Patch (10.96 KB, patch)
2012-10-03 14:18 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (19.90 KB, patch)
2012-10-03 15:01 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.20 KB, patch)
2012-10-03 15:56 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-10-03 14:18:54 PDT
Created attachment 166958 [details] Patch
Eric Seidel (no email)
Comment 2 2012-10-03 14:19:51 PDT
Comment on attachment 166958 [details] Patch LGTM.
Adam Barth
Comment 3 2012-10-03 14:21:43 PDT
@Aaron: The string WebKitBlobBuilder shows up in some extensions, but the 0.006% figure includes usage by extensions.
Early Warning System Bot
Comment 4 2012-10-03 14:42:31 PDT
Comment on attachment 166958 [details] Patch Attachment 166958 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14168017
kov's GTK+ EWS bot
Comment 5 2012-10-03 14:43:10 PDT
Comment on attachment 166958 [details] Patch Attachment 166958 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14132771
Early Warning System Bot
Comment 6 2012-10-03 14:51:55 PDT
Comment on attachment 166958 [details] Patch Attachment 166958 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14132777
Build Bot
Comment 7 2012-10-03 14:55:55 PDT
Comment on attachment 166958 [details] Patch Attachment 166958 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14135799
Adam Barth
Comment 8 2012-10-03 14:57:39 PDT
Comment on attachment 166958 [details] Patch More build system cruft to remove.
Adam Barth
Comment 9 2012-10-03 15:01:06 PDT
Created attachment 166966 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 10 2012-10-03 15:19:49 PDT
Is the build system part (FeatureLists.pm and definitions for each build system) going to be cleaned up in another patch?
Adam Barth
Comment 11 2012-10-03 15:53:12 PDT
(In reply to comment #10) > Is the build system part (FeatureLists.pm and definitions for each build system) going to be cleaned up in another patch? Oh, I see that there's more stuff in the Tools directory. Yeah, I'll do that shortly after this patch lands. Thanks for the tip.
Adam Barth
Comment 12 2012-10-03 15:54:30 PDT
Comment on attachment 166966 [details] Patch Actually, let me do it in one patch.
Adam Barth
Comment 13 2012-10-03 15:56:54 PDT
Created attachment 166980 [details] Patch for landing
WebKit Review Bot
Comment 14 2012-10-03 16:38:38 PDT
Comment on attachment 166980 [details] Patch for landing Clearing flags on attachment: 166980 Committed r130343: <http://trac.webkit.org/changeset/130343>
WebKit Review Bot
Comment 15 2012-10-03 16:38:44 PDT
All reviewed patches have been landed. Closing bug.
Roger Fong
Comment 16 2012-10-03 18:14:27 PDT
So I can't seem to open the WebCore project on Windows in visual studio anymore after this patch :/ The following error has occurred during XML parsing: File: C:\cygwin\home\buildbot\WebKit\OpenSource\Source\WebCore\WebCore.vcproj\WebCore.vcproj Line: 22958 Column: 4 Error Message: Illegal qualified name character. The file 'C:\cygwin\home\buildbot\WebKit\OpenSource\Source\WebCore\WebCore.vcproj\WebCore.vcproj' has failed to load. Any idea why?
Adam Barth
Comment 17 2012-10-03 19:37:29 PDT
Comment on attachment 166980 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=166980&action=review > Source/WebCore/WebCore.vcproj/WebCore.vcproj:22957 > <File Yes. Looks like we need to delete this line as well.
Adam Barth
Comment 18 2012-10-03 20:42:44 PDT
Should be fixed in http://trac.webkit.org/changeset/130358
Roger Fong
Comment 19 2012-10-03 22:06:37 PDT
Great! Thank you much
Raphael Kubo da Costa (:rakuco)
Comment 20 2012-10-04 01:47:34 PDT
I removed one last trace of $legacyWebKitBlobBuilderSupport in <http://trac.webkit.org/changeset/130372>.
Adam Barth
Comment 21 2012-10-04 01:49:12 PDT
Thanks.
Adam Barth
Comment 23 2012-10-04 02:40:06 PDT
I'll fix the tests tomorrow. They're likely just using the API we removed.
Note You need to log in before you can comment on or make changes to this bug.