Summary: | Crash when calling document.open during unload | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, Hironori.Fujii, japhet, ossy, simonjam, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=98345 | ||||||
Bug Depends on: | 98345 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Adam Barth
2012-10-03 11:51:53 PDT
Created attachment 166931 [details]
Patch
Comment on attachment 166931 [details]
Patch
Will this crash the current test or the next one without the patch?
> Will this crash the current test or the next one without the patch?
The current one.
Comment on attachment 166931 [details]
Patch
Ok. I just get worried about unload events causing their failures too late.
Comment on attachment 166931 [details] Patch Clearing flags on attachment: 166931 Committed r130313: <http://trac.webkit.org/changeset/130313> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > (From update of attachment 166931 [details]) > Clearing flags on attachment: 166931 > > Committed r130313: <http://trac.webkit.org/changeset/130313> It caused a crash on the Qt WK2 bot - https://bugs.webkit.org/show_bug.cgi?id=98345 Could you check it, please? Sounds like this test uncovered an existing crash in WebKit2. There's no way this patch introduced the crash. (The patch is just a null check.) |