Bug 98287

Summary: Crash when calling document.open during unload
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, Hironori.Fujii, japhet, ossy, simonjam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=98345
Bug Depends on: 98345    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-10-03 11:51:53 PDT
Crash when calling document.open during unload
Attachments
Patch (3.31 KB, patch)
2012-10-03 11:53 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-10-03 11:53:53 PDT
Created attachment 166931 [details] Patch
Nate Chapin
Comment 2 2012-10-03 11:56:44 PDT
Comment on attachment 166931 [details] Patch Will this crash the current test or the next one without the patch?
Adam Barth
Comment 3 2012-10-03 12:06:59 PDT
> Will this crash the current test or the next one without the patch? The current one.
Nate Chapin
Comment 4 2012-10-03 12:08:55 PDT
Comment on attachment 166931 [details] Patch Ok. I just get worried about unload events causing their failures too late.
WebKit Review Bot
Comment 5 2012-10-03 12:34:21 PDT
Comment on attachment 166931 [details] Patch Clearing flags on attachment: 166931 Committed r130313: <http://trac.webkit.org/changeset/130313>
WebKit Review Bot
Comment 6 2012-10-03 12:34:24 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2012-10-04 00:07:06 PDT
(In reply to comment #5) > (From update of attachment 166931 [details]) > Clearing flags on attachment: 166931 > > Committed r130313: <http://trac.webkit.org/changeset/130313> It caused a crash on the Qt WK2 bot - https://bugs.webkit.org/show_bug.cgi?id=98345 Could you check it, please?
Adam Barth
Comment 8 2012-10-04 00:36:41 PDT
Sounds like this test uncovered an existing crash in WebKit2. There's no way this patch introduced the crash. (The patch is just a null check.)
Note You need to log in before you can comment on or make changes to this bug.