Bug 98263

Summary:

Change RTCPeerConnection GetStats to use Date timestamp format

Product:

WebKit

Reporter:

Harald Alvestrand <hta>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, ojan, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

98392

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Harald Alvestrand

Reported 2012-10-03 07:24:14 PDT

The timestamp format in GetStats was set to "long", which won't work on a 32-bit system. This should be changed to "Date" in IDL, and "double" in C++.

Attachments
Patch (14.17 KB, patch) 2012-10-03 07:32 PDT, Harald Alvestrand	no flags	Details Formatted Diff Diff
Patch (14.14 KB, patch) 2012-10-04 01:50 PDT, Harald Alvestrand	no flags	Details Formatted Diff Diff
Patch (14.04 KB, patch) 2012-10-04 03:34 PDT, Harald Alvestrand	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Harald Alvestrand

Comment 1 2012-10-03 07:32:10 PDT

Created attachment 166889 [details] Patch

WebKit Review Bot

Comment 2 2012-10-03 07:35:08 PDT

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

WebKit Review Bot

Comment 3 2012-10-03 11:03:28 PDT

Comment on attachment 166889 [details] Patch Rejecting attachment 166889 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 154708 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 51>At revision 154708. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14152187

Adam Barth

Comment 4 2012-10-03 11:05:06 PDT

Comment on attachment 166889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166889&action=review > Source/WebCore/ChangeLog:10 > + No new tests (OOPS!). You should remove this line since you've explained where the tests are in the previous line.

Harald Alvestrand

Comment 5 2012-10-04 01:50:14 PDT

Created attachment 167052 [details] Patch

WebKit Review Bot

Comment 6 2012-10-04 02:14:47 PDT

Comment on attachment 167052 [details] Patch Clearing flags on attachment: 167052 Committed r130377: <http://trac.webkit.org/changeset/130377>

WebKit Review Bot

Comment 7 2012-10-04 02:14:51 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 8 2012-10-04 03:00:40 PDT

Re-opened since this is blocked by bug 98392