Bug 98253

Summary: [EFL][WK2] Implement focus/unfocus in UIClient
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, hausmann, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
gyuyoung.kim: review+
Patch for landing none

Description Chris Dumez 2012-10-03 03:41:00 PDT 
We currently don't implement focus/unfocus callbacks in EwkView UIClient. We should provide an implementation for those.
Comment 1 Chris Dumez 2012-10-03 05:05:52 PDT 
Created attachment 166860 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-10-03 05:56:36 PDT 
Comment on attachment 166860 [details]
Patch

LGTM.
Comment 3 Gyuyoung Kim 2012-10-03 06:22:17 PDT 
Comment on attachment 166860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95
> +    evas_object_focus_set(toEwkView(clientInfo), false);

BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way.
Comment 4 Chris Dumez 2012-10-03 06:24:14 PDT 
Comment on attachment 166860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95
>> +    evas_object_focus_set(toEwkView(clientInfo), false);
> 
> BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way.

Yes, takeFocus() implementation is not complete but we do the same in WebKit1.
Comment 5 Gyuyoung Kim 2012-10-03 06:52:45 PDT 
(In reply to comment #4)
> (From update of attachment 166860 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review
> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95
> >> +    evas_object_focus_set(toEwkView(clientInfo), false);
> > 
> > BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way.
> 
> Yes, takeFocus() implementation is not complete but we do the same in WebKit1.

Ok. IMO, it would be good if you say this using "FIXME: bla bla".
Comment 6 Chris Dumez 2012-10-03 06:59:10 PDT 
Created attachment 166885 [details]
Patch for landing

Take Gyuyoung's feedback into consideration.
Comment 7 WebKit Review Bot 2012-10-03 07:32:22 PDT 
Comment on attachment 166885 [details]
Patch for landing

Clearing flags on attachment: 166885

Committed r130285: <http://trac.webkit.org/changeset/130285>
Comment 8 WebKit Review Bot 2012-10-03 07:32:27 PDT 
All reviewed patches have been landed.  Closing bug.