Bug 98252

Summary: Pair NDEBUG optioning in RefCountedBase.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: Web Template FrameworkAssignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, levin+threading, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
benjamin: review-
patch none

Kangil Han
Reported 2012-10-03 03:18:02 PDT
Fixed incomplete NDEBUG option implementation.
Attachments
patch (2.24 KB, patch)
2012-10-03 03:20 PDT, Kangil Han 		benjamin: review-
DetailsFormatted DiffDiff
patch (6.06 KB, patch)
2012-10-03 20:10 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-10-03 03:20:54 PDT
Created attachment 166844 [details] patch
Benjamin Poulain
Comment 2 2012-10-03 12:47:32 PDT
Comment on attachment 166844 [details] patch Your patch is correct. But I think we are abusing NDEBUG here. I would like a new #define based on NDEBUG like we do in HashTable. For example define CHECK_REF_COUNTED_LIFECYCLE if not NDEBUG.
Kangil Han
Comment 3 2012-10-03 20:10:09 PDT
Created attachment 167027 [details] patch Done~
WebKit Review Bot
Comment 4 2012-10-03 23:21:47 PDT
Comment on attachment 167027 [details] patch Clearing flags on attachment: 167027 Committed r130365: <http://trac.webkit.org/changeset/130365>
WebKit Review Bot
Comment 5 2012-10-03 23:21:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.