Bug 98252

Summary:

Pair NDEBUG optioning in RefCountedBase.

Product:

WebKit

Reporter:

Kangil Han <kangil.han>

Component:

Web Template Framework

Assignee:

Kangil Han <kangil.han>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, levin+threading, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	benjamin: review-
patch	none

Description Kangil Han 2012-10-03 03:18:02 PDT

Fixed incomplete NDEBUG option implementation.

Comment 1 Kangil Han 2012-10-03 03:20:54 PDT

Created attachment 166844 [details]
patch

Comment 2 Benjamin Poulain 2012-10-03 12:47:32 PDT

Comment on attachment 166844 [details]
patch

Your patch is correct. But I think we are abusing NDEBUG here. I would like a new #define based on NDEBUG like we do in HashTable.

For example define CHECK_REF_COUNTED_LIFECYCLE if not NDEBUG.

Comment 3 Kangil Han 2012-10-03 20:10:09 PDT

Created attachment 167027 [details]
patch

Done~

Comment 4 WebKit Review Bot 2012-10-03 23:21:47 PDT

Comment on attachment 167027 [details]
patch

Clearing flags on attachment: 167027

Committed r130365: <http://trac.webkit.org/changeset/130365>

Comment 5 WebKit Review Bot 2012-10-03 23:21:50 PDT

All reviewed patches have been landed.  Closing bug.