Bug 98211

Summary:

Do not swallow fatal messages in qt/DumpRenderTree

Product:

WebKit

Reporter:

Peter Rybin <prybin>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy, vsevik, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Peter Rybin 2012-10-02 16:36:47 PDT

Qt version of DumpRenderTree installs qt message handler that swallows fatal messages. Those messages might be highly valuable for basic troubleshooting.

Comment 1 Peter Rybin 2012-10-02 16:56:46 PDT

Created attachment 166778 [details]
Patch

Comment 2 Vsevolod Vlasov 2012-10-03 09:27:09 PDT

Ossy, could you please have a look?

Comment 3 Peter Rybin 2012-10-03 09:50:22 PDT

Created attachment 166913 [details]
Patch

Comment 4 Eric Seidel (no email) 2012-10-08 16:13:35 PDT

Comment on attachment 166913 [details]
Patch

rs=me.

Comment 5 WebKit Review Bot 2012-10-08 16:33:51 PDT

Comment on attachment 166913 [details]
Patch

Clearing flags on attachment: 166913

Committed r130703: <http://trac.webkit.org/changeset/130703>

Comment 6 WebKit Review Bot 2012-10-08 16:33:53 PDT

All reviewed patches have been landed.  Closing bug.