Bug 98196

Summary: executive_unittest fails on Apple Windows bots but not when run locally
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: abarth, dpranke, eric, roger_fong, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
See Also: https://bugs.webkit.org/show_bug.cgi?id=155367
Attachments:
Description Flags
patch none

Roger Fong
Reported 2012-10-02 13:43:01 PDT
py test fails on Apple Windows port. [167/1585] webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process failed: Traceback (most recent call last): File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/common/system/executive_unittest.py", line 167, in serial_test_kill_process self.assertEqual(process.wait(), expected_exit_code) AssertionError: -6 != -9 Test fails only on bots but not when run locally. Unclear why. In addition, sys.platform is "cygwin" not "win32" Creating patch to make test more flexible to handle different behaviors from cygwin.
Attachments
patch (1.67 KB, patch)
2012-10-02 15:06 PDT, Roger Fong 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2012-10-02 15:06:45 PDT
Created attachment 166759 [details] patch
Eric Seidel (no email)
Comment 2 2012-10-02 15:19:12 PDT
Comment on attachment 166759 [details] patch LGTM.
WebKit Review Bot
Comment 3 2012-10-02 15:58:58 PDT
Comment on attachment 166759 [details] patch Clearing flags on attachment: 166759 Committed r130223: <http://trac.webkit.org/changeset/130223>
WebKit Review Bot
Comment 4 2012-10-02 15:59:01 PDT
All reviewed patches have been landed. Closing bug.
Roger Fong
Comment 5 2012-10-02 15:59:47 PDT
reopening to keep track of bug
Note You need to log in before you can comment on or make changes to this bug.