Bug 98163

Summary: Web Inspector: "Load profile..." context menu item has to be shown only for left column with the list of profiles.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Ilya Tikhonovsky
Reported 2012-10-02 08:20:00 PDT
EOM
Attachments
Patch (4.67 KB, patch)
2012-10-02 09:39 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (5.42 KB, patch)
2012-10-02 10:25 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-10-02 09:39:55 PDT
Created attachment 166700 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-10-02 10:25:23 PDT
Created attachment 166708 [details] Patch
Yury Semikhatsky
Comment 3 2012-10-02 23:30:34 PDT
Comment on attachment 166708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166708&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:1253 > + if (profile.canSaveToFile()) { Should it be a test for heap snapshot profile type + canSaveToFile as otherwise it is a bit confusing that all the titles include "Heap Snapshot" ?
Ilya Tikhonovsky
Comment 4 2012-10-03 01:33:51 PDT
Committed r130261: <http://trac.webkit.org/changeset/130261>
Note You need to log in before you can comment on or make changes to this bug.