Bug 98157

Summary: [soup] Timeout support crashes if request already sent
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: PlatformAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: alex, cgarcia, danw, gustavo, mrobinson, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 74802    
Attachments:
Description Flags
Patch none

Dominik Röttsches (drott)
Reported 2012-10-02 07:31:27 PDT
After writing more tests in bug 74802 I found an issue with cleanup for timeouts in ResourceHandleSoup. If a request was already sent out, then the timeout timer expires we start clearing the ResourceHandle - which leads to a RefPtr !m_deletionHasBegun failure when the sendRequestCallback is called. As a solution, I propose to reuse the d->m_cancelled flag for that purpose, and only destroy the handle when one of the progress callbacks is called - as before.
Attachments
Patch (2.13 KB, patch)
2012-10-02 12:26 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2012-10-02 12:26:25 PDT
Created attachment 166732 [details] Patch
Martin Robinson
Comment 2 2012-10-02 12:33:51 PDT
See also: https://bugs.webkit.org/show_bug.cgi?id=98055 Is this bug a duplicate?
Dominik Röttsches (drott)
Comment 3 2012-10-02 13:27:36 PDT
(In reply to comment #2) > See also: https://bugs.webkit.org/show_bug.cgi?id=98055 > > Is this bug a duplicate? Good catch, thanks. *** This bug has been marked as a duplicate of bug 98055 ***
Note You need to log in before you can comment on or make changes to this bug.