Bug 98150

Summary: Web Inspector: NMI: switch to non intrusive instrumentation of ParsedURL
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, benjamin, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Ilya Tikhonovsky
Reported 2012-10-02 05:07:54 PDT
EOM
Attachments
Patch (15.18 KB, patch)
2012-10-02 05:14 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-10-02 05:14:02 PDT
Created attachment 166675 [details] Patch
WebKit Review Bot
Comment 2 2012-10-02 10:55:43 PDT
Comment on attachment 166675 [details] Patch Clearing flags on attachment: 166675 Committed r130187: <http://trac.webkit.org/changeset/130187>
WebKit Review Bot
Comment 3 2012-10-02 10:55:47 PDT
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 4 2012-10-04 17:28:32 PDT
Guys, I really wish you #ifdef-ed WTFURL instead of making the build break even worse :( :( :(
Ilya Tikhonovsky
Comment 5 2012-10-04 22:44:21 PDT
(In reply to comment #4) > Guys, I really wish you #ifdef-ed WTFURL instead of making the build break even worse :( :( :( It is not clear for me what do you mean. Could you please point me to the build log with compile time error or to the configuration which was broken by the patch and I'll fix it.
Benjamin Poulain
Comment 6 2012-10-04 22:56:06 PDT
> It is not clear for me what do you mean. > Could you please point me to the build log with compile time error or to the configuration which was broken by the patch and I'll fix it. WTFURL is not compiled by default. + info.addMember(arrayBuffer->spec()); arrayBuffer is not defined. spec() is not const. It's fix, I'll upload everything this weekend.
Note You need to log in before you can comment on or make changes to this bug.