Summary: | Implement GraphicsSurface for Windows. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zeno Albisser <zeno> | ||||||
Component: | WebKit2 | Assignee: | Zeno Albisser <zeno> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abecsi, hausmann, noam, vestbo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 98501, 99709 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Zeno Albisser
2012-10-02 04:41:01 PDT
Created attachment 170348 [details]
Patch
Attachment 170348 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:351: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 170348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170348&action=review >> Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:353 >> + 1, 1 > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Indentation is like that on purpose. Comment on attachment 170348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170348&action=review > Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:6 > +/* > + > + Copyright (C) 2012 Zeno Albisser <zeno@webkit.org> > + > + This library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Library General Public I think we normally have *'s here in the beginning of each line > Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:79 > + initShaderProgram(); webkit usually uses initialize* > Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:488 > + if (m_private) > + delete m_private; That if is not needed (In reply to comment #4) > I think we normally have *'s here in the beginning of each line Depends on the licence header, we have both. I aligned with GraphicsContext3DQt.cpp, GraphicsSurface.h, GraphicsSurface.cpp and others. > webkit usually uses initialize* I'll fix that. > > + if (m_private) > > + delete m_private; > That if is not needed i'll fix that as well. Created attachment 170374 [details]
Patch
Attachment 170374 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:351: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 170374 [details]
Patch
r=me as this is at least a good start
Comment on attachment 170374 [details] Patch Clearing flags on attachment: 170374 Committed r132343: <http://trac.webkit.org/changeset/132343> All reviewed patches have been landed. Closing bug. Comment on attachment 170374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170374&action=review > Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:3 > + Copyright (C) 2012 Zeno Albisser <zeno@webkit.org> Shouldn't this at least include Digia? > Shouldn't this at least include Digia?
I will add this the next time i touch the file.
|