Summary: | Week specifiers defined in DateTimeFormat class are wrong. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||
Component: | Platform | Assignee: | yosin | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | caseq, mifenton, ojan, tkent, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 97877, 98120 | ||||||
Attachments: |
|
Description
yosin
2012-10-01 19:01:43 PDT
Created attachment 166591 [details]
Patch 1
Comment on attachment 166591 [details]
Patch 1
Could you review this patch?
Thanks in advance.
Comment on attachment 166591 [details]
Patch 1
ok
Comment on attachment 166591 [details] Patch 1 Clearing flags on attachment: 166591 Committed r130116: <http://trac.webkit.org/changeset/130116> All reviewed patches have been landed. Closing bug. This caused two webkit_unit_test failures. Maybe the tests need updating? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=DateTimeFormatTest.SingleUpperCaseCharacter%2CDateTimeFormatTest.SingleLowerCaseCharacter (In reply to comment #6) > This caused two webkit_unit_test failures. Maybe the tests need updating? > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=DateTimeFormatTest.SingleUpperCaseCharacter%2CDateTimeFormatTest.SingleLowerCaseCharacter Yes, I field a bug 98120, for updating tests. Comment on attachment 166591 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=166591&action=review > Source/WebCore/ChangeLog:12 > + No new tests. Following existing tests cover this change: Why no new tests? Is this really not a testable change? (In reply to comment #8) > (From update of attachment 166591 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166591&action=review > > > Source/WebCore/ChangeLog:12 > > + No new tests. Following existing tests cover this change: > > Why no new tests? Is this really not a testable change? This is testable change. There are layoyut tests listed in ChangeLog and webkit_unit_tests, sorry I forgot to include this in this patch, in bug 98120. |