Bug 98097

Summary: Attempt to simplify IPC message dispatching logic in WebKit2
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, bw80.lee, cmarcelo, gtk-ews, gustavo, gyuyoung.kim, menard, philn, rakuco, webkit.review.bot, xan.lopez, zan, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2012-10-01 17:07:12 PDT
Attempt to simplify IPC message dispatching logic in WebKit2
Attachments
Patch (27.55 KB, patch)
2012-10-01 17:13 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (28.11 KB, patch)
2012-10-02 10:53 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (28.11 KB, patch)
2012-10-02 12:59 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (28.09 KB, patch)
2012-10-02 13:44 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-01 17:13:56 PDT
Created attachment 166577 [details] Patch
kov's GTK+ EWS bot
Comment 2 2012-10-01 18:30:18 PDT
Comment on attachment 166577 [details] Patch Attachment 166577 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14130085
kov's GTK+ EWS bot
Comment 3 2012-10-01 18:35:03 PDT
Comment on attachment 166577 [details] Patch Attachment 166577 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14124154
Anders Carlsson
Comment 4 2012-10-02 10:53:18 PDT
Created attachment 166713 [details] Patch
Anders Carlsson
Comment 5 2012-10-02 12:35:23 PDT
Not sure why the GTK+ bot isn't finding the new files - I'm going to land this anyway and see if it breaks the build.
Anders Carlsson
Comment 6 2012-10-02 12:59:57 PDT
Created attachment 166737 [details] Patch
Anders Carlsson
Comment 7 2012-10-02 13:00:19 PDT
(In reply to comment #5) > Not sure why the GTK+ bot isn't finding the new files - I'm going to land this anyway and see if it breaks the build. Looks like i used spaces instead of tabs in the Makefile. Trying again.
Anders Carlsson
Comment 8 2012-10-02 13:44:39 PDT
Created attachment 166743 [details] Patch
Anders Carlsson
Comment 9 2012-10-02 14:02:26 PDT
Committed r130207: <http://trac.webkit.org/changeset/130207>
Zan Dobersek
Comment 10 2012-10-03 00:10:37 PDT
(In reply to comment #7) > (In reply to comment #5) > > Not sure why the GTK+ bot isn't finding the new files - I'm going to land this anyway and see if it breaks the build. > > Looks like i used spaces instead of tabs in the Makefile. Trying again. It still broke the build, but fixed in r130257. http://trac.webkit.org/changeset/130257
Note You need to log in before you can comment on or make changes to this bug.